Tracking PR for Plonky3 v0.4.2 #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adr1anh
added
the
no changelog
huitseeker
force-pushed
the
huitseeker/p3-rebased
branch
3 times, most recently
from
d074220 to
23d2246
Compare
Contributor
Author
|
Currently in the process of rebasing. I'll wait until plonky3 v0.4.2 is released later today. |
adr1anh
force-pushed
the
tracking-p3-0.4.2
branch
from
5ef03ad to
5f8c3c5
Compare
Contributor
Author
|
This PR will be ready for review once 0xMiden/p3-miden#3 is approved and released on crates.io. |
adr1anh
commented
Jan 5, 2026
adr1anh
commented
Jan 5, 2026
This was referenced Jan 6, 2026
huitseeker
approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Nit: I think this can fix #731. See comment below.
Edit: Fixed. This will need edition to pull the upcoming published p3-miden.
Migrate from the Miden-specific `p3-miden-goldilocks` crate to the upstream `p3-goldilocks` from Plonky3. This aligns with the upstream ecosystem and reduces fork maintenance. Changes: - Update Cargo.toml deps to use Plonky3 main branch for p3-* crates - Replace all `p3_miden_goldilocks` imports with `p3_goldilocks` - Add `p3-util` dependency for slice utilities - Update `as_int()` calls to `as_canonical_u64()` (P3 API) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Update p3-miden crates from commit 9553dc68 to 134c14d3. This fixes the cargo-deny CI failure caused by duplicate p3-* crate entries (v0.4.1 from git vs v0.4.2 from crates.io). The newer p3-miden commits properly depend on p3-* v0.4.2 from crates.io instead of v0.4.1 from the Plonky3 git repository. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add allow-org exception for the 0xMiden GitHub organization to permit p3-miden crates which are not yet published to crates.io. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
huitseeker
force-pushed
the
tracking-p3-0.4.2
branch
from
438e75a to
c20e9b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
nextaccording to naming convention.